Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby,gatsby-adapter-netlify): support pathPrefix and trailingSlash options (#38666) #38701

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

gatsbybot
Copy link
Collaborator

Backporting #38666 to the 5.12 release branch

(cherry picked from commit 63e57cf)

…lash options (#38666)

* initial wip

* prefix all the things

* lambda handler stripping path prefix

* test: adjust e2e setup to also run variant with path prefix and no trailing slashes

* chore: use queue for file moving to limit concurrency

* tmp: don't clean up deploys while debugging things

* test: added variant variables to deploy title

* fix TS

* fix unit tests

* try different cypress group

* try different cypress group2

* maybe fix passing cypress env?

* fix ssr path_prefix

* keep 404/500 status pages in original place

* fix typo

* fix assertion?

* streamline file moving logic

* cache (and restore) publishdir locally too

* add pretty-url unit tests

* handle dynamic paths when generating pretty url file names

* update intercepting glob to handle path prefix

* update intercepting glob to handle path prefix 2

* restore automatic deploys deletion

* test: jest ensure we mount files that we test filepaths for

* handle path prefix in header rules

* drop debug helpers

* first check if local

* drop debug log

* handle external redirects when pathPrefix is used. Thanks @techfg

* make placeholder syntax consistent

* update comment

* move dynamic route path normalization to its own function

(cherry picked from commit 63e57cf)
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 16, 2023
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 16, 2023
@pieh pieh merged commit 1090558 into release/5.12 Nov 20, 2023
33 checks passed
@pieh pieh deleted the backport-5.12-38666 branch November 20, 2023 14:26
This was referenced Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants